Add downgrade cancellation e2e tests #19252
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: henrybear327 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 25 files with indirect coverage changes @@ Coverage Diff @@
## main #19252 +/- ##
==========================================
+ Coverage 68.79% 68.87% +0.08%
==========================================
Files 420 420
Lines 35674 35674
==========================================
+ Hits 24543 24572 +29
+ Misses 9706 9684 -22
+ Partials 1425 1418 -7 Continue to review full report in Codecov by Sentry.
|
| ret[i] = &version.Versions{ | ||
| Cluster: ver.String(), | ||
| Server: e2e.OffsetMinor(ver, 1).String(), | ||
| Storage: "", |
There was a problem hiding this comment.
Will continue to investigate this tomorrow
Signed-off-by: Chun-Hung Tseng <[email protected]> Co-authored-by: Benjamin Wang <[email protected]>
Signed-off-by: Chun-Hung Tseng <[email protected]>
Signed-off-by: Chun-Hung Tseng <[email protected]>
Signed-off-by: Chun-Hung Tseng <[email protected]>
henrybear327
force-pushed
the
e2e/downgrade_cancellation_partial
branch
from
fe607d8 to
1ae6cba
Compare
Part 2 of the e2e test - downgrade cancellation is called after the cluster has been partially downgraded
This PR is currently based on #19244, thus, it's put in draft mode for now.
Reference: #17976
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.